Developer Expectations: Collaboration

I review my colleagues' code to help them and I submit reviews that make it easy for my colleagues to help me

  1. I explain what my PR is designed to achieve
  2. My PRs are focused within well defined boundaries and small enough to be reviewed
  3. Pull requests/our code review process is a first class citizen of what I produce
  4. I write concise commit messages that explain why I have changed the code
  5. I ensure that my Pull Requests are seen through to completion in a reasonable time frame
  6. I leave friendly, constructive feedback for my colleagues when pairing and reviewing their code
  7. I use PRs as a way to deliver quality code
  8. I plus-one a Pull Request when I feel it is production ready
  9. I make the call about when a PR has enough support to merge and deploy